Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended wait logic to ibm_resource_tag #5251

Merged
merged 2 commits into from Apr 2, 2024
Merged

Extended wait logic to ibm_resource_tag #5251

merged 2 commits into from Apr 2, 2024

Conversation

ujjwal-ibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/globaltagging TESTARGS='-run=TestAccResourceTag_Wait'
=== RUN   TestAccResourceTag_Wait
--- PASS: TestAccResourceTag_Wait (102.57s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/globaltagging   104.798s

hkantare
hkantare reviewed Mar 30, 2024
View reviewed changes
ibm/flex/structures.go
@@ -2559,7 +2559,7 @@ func UpdateGlobalTagsUsingCRN(oldList, newList interface{}, meta interface{}, re
if err != nil {
return fmt.Errorf("[ERROR] Error updating database tags %v : %s\n%s", add, err, resp)
}
response, errored := waitForTagsAvailable(meta, resourceID, resourceType, tagType, news, 30*time.Second)
response, errored := WaitForTagsAvailable(meta, resourceID, resourceType, tagType, news, 30*time.Second)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of harcoded 30 sec declare timeouts in schema

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to timeout, default is 30 seconds and updated the docs

@ujjwal-ibm
Copy link
Contributor Author 

% make testacc TEST=./ibm/service/globaltagging TESTARGS='-run=TestAccResourceTag_Wait'
=== RUN   TestAccResourceTag_Wait
--- PASS: TestAccResourceTag_Wait (98.73s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/globaltagging   100.640s

@hkantare hkantare merged commit 3247514 into IBM-Cloud:master Apr 2, 2024
1 check passed
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Apr 11, 2024
@ujjwal-ibm @ismirlia
Extended wait logic to ibm_resource_tag (IBM-Cloud#5251)
6d10476 
* Extended wait logic to ibm_resource_tag

* Moved hardcoded wait time to timeout as per review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ujjwal-ibm @hkantare