fix(ibm_database resource): Fix cpuEnforcement multitenant bug

[omaraibrahim]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Description

We were making calls to get the multitenant cpu_enforcement_ratios for databases that do not support multitenant. The API would reply with an error. This fix makes sure that we don't try to get the cpu_enforcement_ratios in the event that a databases is NOT multitenant.

It also enhances the way we report errors for databases that do not support multitenant.

Displays error messages if an invalid host_flavor is passed.

Examples of Fix Working

Mongodb Enterprise

data "ibm_resource_group" "group" {
  name = "default"
}

resource "ibm_database" "test_acc" {
  name              = "coolguy-mongodb-two"
  plan              = "enterprise"
  location          = "eu-gb"
  service           = "databases-for-mongodb"
  resource_group_id = data.ibm_resource_group.group.id
   group {
    group_id = "member"
  } 
}

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

EnterpriseDB

data "ibm_resource_group" "group" {
  name = "default"
}

resource "ibm_database" "test_acc" {
  name              = "coolguy-edb-two"
  plan              = "standard"
  location          = "eu-gb"
  service           = "databases-for-enterprisedb"
  resource_group_id = data.ibm_resource_group.group.id
   group {
    group_id = "member"
  } 
}

New Error Messaging

resource "ibm_database" "mongdb" {
  name              = "coolguy-mongo"
  plan              = "enterprise"
  location          = "us-south"
  service           = "databases-for-mongodb"
  resource_group_id = data.ibm_resource_group.group.id

  group {
    group_id = "member"

    host_flavor {
      id = "multitenant"      
    }
  }
}

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: 1 error occurred:
│ 	* mongodbee is not available on multitenant

Host Flavor Validation

resource "ibm_database" "test_acc" {
  name              = "coolguy-mongodb-two"
  plan              = "enterprise"
  location          = "eu-gb"
  service           = "databases-for-mongodb"
  resource_group_id = data.ibm_resource_group.group.id
   group {
    group_id = "member"
    host_flavor {
      id = "notValid"      
    }
  } 
}

│ Error: expected group.0.host_flavor.0.id to be one of ["multitenant" "b3c.4x16.encrypted" "b3c.8x32.encrypted" "m3c.8x64.encrypted" "b3c.16x64.encrypted" "b3c.32x128.encrypted" "m3c.30x240.encrypted"], got notValid

Output from acceptance testing:

$ make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstance_Redis_Basic'
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (1427.93s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1429.586s

make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMMongoDBEnterpriseDatabaseInstanceBasic'
--- PASS: TestAccIBMMongoDBEnterpriseDatabaseInstanceBasic (8161.14s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	8162.930s

[alexhemard]

Do you mean 0, 1 ?

[alexhemard]

LGTM