-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(notebooks): add Krylov subspace expansion tutorial #11
Conversation
Pull Request Test Coverage Report for Build 8472840764Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Hi @miamico can you check that this notebook runs with a freshly created environment and only this repo installed from source? Please make sure to install the Since Friday, this should be equivalent to Qiskit If you need additional dependencies please flag. |
I've modified the notebook to work on qiskit 1.0. Verified that it runs top to bottom installing the repo dependencies and qiskit 1.0. Note that when installing the optional dependencies with the command: |
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
...lculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Outdated
Show resolved
Hide resolved
I think this is a good 'starter kit' for someone looking to try and explore using the krylov method. Given similar focus on Heisenberg chains, and in context of this existing related tutorial, I wonder if a title 'Heisenberg Chains with quantum krylov subspace expansion' might be an apt name -- thoughts? The text is very verbose, but I think this is useful with respect to learning about krylov method. May be worth considering future updates to leave out edu content for tutorials and include this in other edu sections. |
The file is now called: |
I'm afraid to emphasize too much Heisemberg chain as that may give the impression that this technique is specifically for this case while I want to focus more on the technique itself. Open to further discussions. I agree on the verbose part. We can figure out what is the right amount of information. |
I missed this comment before @miamico, can you mention me in the future so that I get notified? This is/was already referenced in INSTALL.md. Can you see it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miamico!
I have not gotten to the contents of the guide, but we need to do these two things before merging is possible:
- Merge
main
into this branch to get the latest updates.- Remove the word
guide
from the file name.The file is now called:
Calculating ground states on large scale systems with the quantum krylov subspace method.ipynb
Wow, that is a long name for a file! I would suggest:
- Short names
- Avoid spaces
How about just krylov.ipynb
@miamico?
Oh yes I saw it now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notebook looks great! I suggest some minor changes.
@miamico , can you mark as resolved the comments that you have already addressed? If everything is okay with the rest I think we should be ready to mereg |
Yep, I've addressed the various comments. I think it's ready to be merged |
Originally created in IBM-Quantum-Technical-Enablement/quantum-enablement#11
Summary
Adding a tutorial on finding the ground state energy of a given Hamiltonian (Heisenberg model) using the Krylov subspace expansion techniques.
Details and comments
The tutorial is formatted in the Qiskit Patterns framework with a detailed description of the method in Step 1., optimization of the circuits in Step 2., execution with the primitives on a simulator in Step 3. and post-processing of the results to get the value of the ground state energy of the system in Step 4.