generated from pedrorrivero/pyproject-qiskit
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(circuits): add QAOAPathCircuit
class
#14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorrivero
added
feature
New feature request
PL-2
Priority level 2/5 → Medium-high
labels
Feb 24, 2024
Pull Request Test Coverage Report for Build 8441529388Details
💛 - Coveralls |
pedrorrivero
changed the title
feat(circuits): add QAOALineCircuit
feat(circuits): add QAOALineCircuit class
Feb 24, 2024
pedrorrivero
changed the title
feat(circuits): add QAOALineCircuit class
feat(circuits): add Feb 24, 2024
QAOALineCircuit
class
4 tasks
a-matsuo
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. It seems good. However, the name, 'QAOALineCircuit' might need to change.
pedrorrivero
changed the title
feat(circuits): add
feat(circuits): add Mar 18, 2024
QAOALineCircuit
classQAOAPathCircuit
class
a-matsuo
previously approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds new
QAOAPathCircuit
class to create parameterized QAOA quantum circuits for path acyclic graphs, at varying number of qubits and two-qubit depth.Details and comments