Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(circuits): add MBLChainCircuit class #15

Merged
merged 5 commits into from
Mar 27, 2024
Merged

feat(circuits): add MBLChainCircuit class #15

merged 5 commits into from
Mar 27, 2024

Conversation

pedrorrivero
Copy link
Member

Summary

Adds new MBLChainCircuit class to create parameterized MBL quantum circuits for non-periodic spin chains, at varying number of qubits and two-qubit depth.

Details and comments

  • This is a utility class to avoid building these (well-known) circuits manually in present and upcoming notebooks.
  • Needed for the Utility Scaling notebook, demoed at IBM Quantum Practitioner's Forum 2023.

@pedrorrivero pedrorrivero added feature New feature request PL-2 Priority level 2/5 → Medium-high labels Feb 24, 2024
@pedrorrivero pedrorrivero self-assigned this Feb 24, 2024
@coveralls
Copy link

coveralls commented Feb 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8455892397

Details

  • 52 of 52 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 8441575041: 0.0%
Covered Lines: 290
Relevant Lines: 290
💛 - Coveralls

@pedrorrivero pedrorrivero changed the title feat(circuits): add MBLChainCircuit feat(circuits): add MBLChainCircuit class Feb 24, 2024
@pedrorrivero pedrorrivero changed the title feat(circuits): add MBLChainCircuit class feat(circuits): add MBLChainCircuit class Feb 24, 2024
@pedrorrivero pedrorrivero mentioned this pull request Feb 28, 2024
Merged
4 tasks
miamico
miamico requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@miamico miamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Only some minor comments

quantum_enablement/circuits/_mbl.py Outdated Show resolved Hide resolved
quantum_enablement/circuits/_mbl.py Show resolved Hide resolved
miamico
miamico approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@miamico miamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedrorrivero pedrorrivero merged commit 9f28b81 into main Mar 27, 2024
11 checks passed
@pedrorrivero pedrorrivero deleted the mbl branch March 27, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miamico miamico miamico approved these changes

@haimeng-zhang haimeng-zhang Awaiting requested review from haimeng-zhang

@dsvandet dsvandet Awaiting requested review from dsvandet

Assignees

@pedrorrivero pedrorrivero

Labels
feature New feature request PL-2 Priority level 2/5 → Medium-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pedrorrivero @coveralls @miamico