Issue340 reverseproxy config idempotency #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code improves idempotency for editing entries. It closes #340.
This is only applicable for the
entries
style of writing, where you can update multiple entries at once.The code also does a more efficient check, by doing a single call per stanza instead of a call per entry (get_all instead of get).
That, however, does not make a noticable difference in performance.
That idempotency now works better, obvioulsy does make a huge difference in performance (when there are no changes), though.
These tests need to run twice, to demonstrate idempotency. If you run these with the current code, you'll see the idempotency check fails.
I've also updated the readme to be in line with what is mentioned in the ibm.isam Ansible Collection.