fix: make byteArray return empty array on failure instead of fatal error #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 🙂 Would be nice to have a test. |
|
I understand the rationale behind the PR but I just want make sure you know that it’s a potential source breaking change. The unexpected empty array could cause problems that could be difficult to detect and find. Have you considered this? @ianpartridge, you ok with this? |
|
Yeah I think we should make this change, the current behaviour is dangerous. |
|
So the only way this impacts existing applications is that if it was previously throwing a fatal error. This makes it unlikely that this will change expected behavior. In the next major release of BlueCryptor this function should probably throw but I think this fix will solve the current issue in a non breaking way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes byteArray so that on failure it returns an empty array instead of throwing a fatal error.
Motivation and Context
This is required because you make pass user code into the function (such as in Kitura-Session where a users Cookie is decoded). If it throws a fatal error on failure then a user can crash the system. If it returns an empty array the application can handle this in the correct way.
How Has This Been Tested?
This has been tested within Kitura-Session. Using this code makes the session reject the cookie instead of throwing a fatal error and crashing the server.
Checklist: