Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define a Kitura.logTo() function for logging via swift-log #1460

Merged
merged 4 commits into from
Jun 6, 2019
Merged

feat: Define a Kitura.logTo() function for logging via swift-log #1460

merged 4 commits into from
Jun 6, 2019

Conversation

djones6
Copy link
Collaborator

@djones6 djones6 commented Jun 5, 2019

Description

Depends on: Kitura/LoggerAPI#47

Convenience method of configuring Kitura to log to a swift-log logger, without requiring the user to depend on and import LoggerAPI.

Motivation and Context

LoggerAPI can now be configured to direct log messages to a swift-log Logger, instead of (or in addition to) a LoggerAPI backend (such as HeliumLogger).

Users who just want to use Kitura and swift-log would otherwise need to import LoggerAPI so that they can configure Log.swiftLogger. This simplifies things by providing a simple Kitura.logTo() function which accepts a swift-log Logger.

How Has This Been Tested?

Checklist:

  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@djones6 djones6 requested a review from ianpartridge June 5, 2019 16:08
@djones6 djones6 merged commit e9eeb85 into Kitura:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants