Skip to content

Commit

Permalink
Added a basic Info.plist file (#37)
Browse files Browse the repository at this point in the history
It prevents the following error while trying to validate or upload a project using this framework to the App Store via iTunes Connect

iTunes Store operation failed.
This bundle path.to/Frameworks/HTMLEntities.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.
  • Loading branch information
remuslazar authored and youming-lin committed Sep 14, 2017
1 parent 334e9de commit 7b6bd41
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
16 changes: 16 additions & 0 deletions HTMLEntities-Carthage.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
/* End PBXContainerItemProxy section */

/* Begin PBXFileReference section */
D8835F911F69ABA100694AD9 /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
OBJ_10 /* ParseError.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ParseError.swift; sourceTree = "<group>"; };
OBJ_11 /* String+HTMLEntities.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "String+HTMLEntities.swift"; sourceTree = "<group>"; };
OBJ_12 /* Utilities.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Utilities.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -58,6 +59,14 @@
/* End PBXFrameworksBuildPhase section */

/* Begin PBXGroup section */
D8835F921F69ABD800694AD9 /* Supporting Files */ = {
isa = PBXGroup;
children = (
D8835F911F69ABA100694AD9 /* Info.plist */,
);
name = "Supporting Files";
sourceTree = "<group>";
};
OBJ_13 /* Tests */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -91,6 +100,7 @@
OBJ_6 /* Package.swift */,
OBJ_7 /* Sources */,
OBJ_13 /* Tests */,
D8835F921F69ABD800694AD9 /* Supporting Files */,
OBJ_17 /* docs */,
OBJ_18 /* Products */,
);
Expand Down Expand Up @@ -214,6 +224,7 @@
isa = XCBuildConfiguration;
buildSettings = {
APPLICATION_EXTENSION_API_ONLY = YES;
CURRENT_PROJECT_VERSION = 1;
ENABLE_TESTABILITY = YES;
FRAMEWORK_SEARCH_PATHS = (
"$(inherited)",
Expand All @@ -236,6 +247,7 @@
isa = XCBuildConfiguration;
buildSettings = {
APPLICATION_EXTENSION_API_ONLY = YES;
CURRENT_PROJECT_VERSION = 1;
ENABLE_TESTABILITY = YES;
FRAMEWORK_SEARCH_PATHS = (
"$(inherited)",
Expand All @@ -260,10 +272,12 @@
CLANG_ENABLE_OBJC_ARC = YES;
COMBINE_HIDPI_IMAGES = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 1;
DEBUG_INFORMATION_FORMAT = dwarf;
DYLIB_INSTALL_NAME_BASE = "@rpath";
ENABLE_NS_ASSERTIONS = YES;
GCC_OPTIMIZATION_LEVEL = 0;
INFOPLIST_FILE = Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
ONLY_ACTIVE_ARCH = YES;
Expand Down Expand Up @@ -320,9 +334,11 @@
CLANG_ENABLE_OBJC_ARC = YES;
COMBINE_HIDPI_IMAGES = YES;
COPY_PHASE_STRIP = YES;
CURRENT_PROJECT_VERSION = 1;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DYLIB_INSTALL_NAME_BASE = "@rpath";
GCC_OPTIMIZATION_LEVEL = s;
INFOPLIST_FILE = Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
OTHER_SWIFT_FLAGS = "-DXcode";
Expand Down
8 changes: 8 additions & 0 deletions Info.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>CFBundleVersion</key>
<string>$(CURRENT_PROJECT_VERSION)</string>
</dict>
</plist>

0 comments on commit 7b6bd41

Please sign in to comment.