Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detectors api #305

Merged
merged 4 commits into from May 5, 2022
Merged

Add detectors api #305

merged 4 commits into from May 5, 2022

Conversation

Adebayo-Oshingbesan
Copy link
Contributor

Signed-off-by: Adebayo Oshingbesan adebayo.oshingbesan1@ibm.com

This pull request adds the new detectors api for extending mdss beyond binary classification

Signed-off-by: Adebayo Oshingbesan <adebayo.oshingbesan1@ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented May 2, 2022

This pull request introduces 3 alerts and fixes 1 when merging 92a7568 into 73263a3 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

fixed alerts:

  • 1 for Unused import

Signed-off-by: Adebayo Oshingbesan adebayo.oshingbesan1@ibm.com
Signed-off-by: Adebayo Oshingbesan <Adebayo.Oshingbesan1@ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented May 2, 2022

This pull request fixes 1 alert when merging 52006a7 into 73263a3 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@hoffmansc hoffmansc closed this May 3, 2022
@hoffmansc hoffmansc reopened this May 3, 2022
Copy link
Collaborator

@hoffmansc hoffmansc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for all your hard work on this!

aif360/sklearn/detectors/detectors.py Outdated Show resolved Hide resolved
Signed-off-by: Adebayo Oshingbesan <adebayo.oshingbesan1@ibm.com>
Signed-off-by: Adebayo Oshingbesan <adebayo.oshingbesan1@ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented May 5, 2022

This pull request fixes 1 alert when merging 7e0c9dd into 455cc23 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@Adebayo-Oshingbesan
Copy link
Contributor Author

Hi @hoffmansc. I have implemented the changes as requested.

@hoffmansc hoffmansc merged commit 9eae520 into Trusted-AI:master May 5, 2022
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants