Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve output of openshift-installer progress and check #61

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

smolin-de
Copy link
Contributor

The openshift-installer requires up to 60 min to complete. You need to check manually if the install process started sucessfully or you simply wait 60 min for the results.
This patch monitors the 'node-bootstrapper' request. Usually such request is raised within 6 min. If not, then this is considered as an error and the ansible playbook script exits.

The openshift-installer process is not aborted! It is still running.

Signed-off-by: Klaus Smolin smolin@de.ibm.com

smolin-de and others added 2 commits January 12, 2023 17:54
The openshift-installer requires up to 60 min to complete.
You need to check manually if the install process started sucessfully
or you simply wait 60 min for the results.
This patch monitors the 'node-bootstrapper' request. Usually such
request is raised within 6 min. If not, then this is considered as an
error and the ansible playbook script exits.

The openshift-installer process is not aborted! It is still running.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
Added a lowercase jinja filter because some users might type in their hostnames in all caps (like I did) in all.yaml and that causes the task 'wait for control node CSRs (retry every 30s)' to timeout even though the item it's looking for is there.

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
Copy link
Collaborator

@jacobemery jacobemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and it looks great! I just had to add the lowercase filter just in case the user sets their hostnames in all.yaml in all caps (like I did), which caused it to timeout even though the value the task was checking for was present.

@jacobemery jacobemery merged commit e744751 into IBM:main Jan 13, 2023
@smolin-de smolin-de deleted the improve_wait_bootstrap branch January 13, 2023 07:52
AmadeusPodvratnik pushed a commit to AmadeusPodvratnik/Ansible-OpenShift-Provisioning that referenced this pull request Jan 19, 2023
The openshift-installer requires up to 60 min to complete. You need to
check manually if the install process started sucessfully or you simply
wait 60 min for the results.
This patch monitors the 'node-bootstrapper' request. Usually such
request is raised within 6 min. If not, then this is considered as an
error and the ansible playbook script exits.

The openshift-installer process is not aborted! It is still running.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
Co-authored-by: Jacob Emery <jacob.emery@ibm.com>
Signed-off-by: Amadeus Podvratnik <pod@de.ibm.com>
AmadeusPodvratnik pushed a commit to AmadeusPodvratnik/Ansible-OpenShift-Provisioning that referenced this pull request Jan 19, 2023
The openshift-installer requires up to 60 min to complete. You need to
check manually if the install process started sucessfully or you simply
wait 60 min for the results.
This patch monitors the 'node-bootstrapper' request. Usually such
request is raised within 6 min. If not, then this is considered as an
error and the ansible playbook script exits.

The openshift-installer process is not aborted! It is still running.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
Co-authored-by: Jacob Emery <jacob.emery@ibm.com>
Signed-off-by: Amadeus Podvratnik <pod@de.ibm.com>
AmadeusPodvratnik pushed a commit to AmadeusPodvratnik/Ansible-OpenShift-Provisioning that referenced this pull request Jan 19, 2023
The openshift-installer requires up to 60 min to complete. You need to
check manually if the install process started sucessfully or you simply
wait 60 min for the results.
This patch monitors the 'node-bootstrapper' request. Usually such
request is raised within 6 min. If not, then this is considered as an
error and the ansible playbook script exits.

The openshift-installer process is not aborted! It is still running.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
Co-authored-by: Jacob Emery <jacob.emery@ibm.com>
Signed-off-by: Amadeus Podvratnik <pod@de.ibm.com>
@jacobemery
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jacobemery added a commit that referenced this pull request Dec 20, 2023
The openshift-installer requires up to 60 min to complete. You need to
check manually if the install process started sucessfully or you simply
wait 60 min for the results.
This patch monitors the 'node-bootstrapper' request. Usually such
request is raised within 6 min. If not, then this is considered as an
error and the ansible playbook script exits.

The openshift-installer process is not aborted! It is still running.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
Co-authored-by: Jacob Emery <jacob.emery@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants