-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve output of openshift-installer progress and check #61
Conversation
The openshift-installer requires up to 60 min to complete. You need to check manually if the install process started sucessfully or you simply wait 60 min for the results. This patch monitors the 'node-bootstrapper' request. Usually such request is raised within 6 min. If not, then this is considered as an error and the ansible playbook script exits. The openshift-installer process is not aborted! It is still running. Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
Added a lowercase jinja filter because some users might type in their hostnames in all caps (like I did) in all.yaml and that causes the task 'wait for control node CSRs (retry every 30s)' to timeout even though the item it's looking for is there. Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
0385def
to
e2d826d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out and it looks great! I just had to add the lowercase filter just in case the user sets their hostnames in all.yaml in all caps (like I did), which caused it to timeout even though the value the task was checking for was present.
The openshift-installer requires up to 60 min to complete. You need to check manually if the install process started sucessfully or you simply wait 60 min for the results. This patch monitors the 'node-bootstrapper' request. Usually such request is raised within 6 min. If not, then this is considered as an error and the ansible playbook script exits. The openshift-installer process is not aborted! It is still running. Signed-off-by: Klaus Smolin <smolin@de.ibm.com> Signed-off-by: Jacob Emery <jacob.emery@ibm.com> Co-authored-by: Jacob Emery <jacob.emery@ibm.com> Signed-off-by: Amadeus Podvratnik <pod@de.ibm.com>
The openshift-installer requires up to 60 min to complete. You need to check manually if the install process started sucessfully or you simply wait 60 min for the results. This patch monitors the 'node-bootstrapper' request. Usually such request is raised within 6 min. If not, then this is considered as an error and the ansible playbook script exits. The openshift-installer process is not aborted! It is still running. Signed-off-by: Klaus Smolin <smolin@de.ibm.com> Signed-off-by: Jacob Emery <jacob.emery@ibm.com> Co-authored-by: Jacob Emery <jacob.emery@ibm.com> Signed-off-by: Amadeus Podvratnik <pod@de.ibm.com>
The openshift-installer requires up to 60 min to complete. You need to check manually if the install process started sucessfully or you simply wait 60 min for the results. This patch monitors the 'node-bootstrapper' request. Usually such request is raised within 6 min. If not, then this is considered as an error and the ansible playbook script exits. The openshift-installer process is not aborted! It is still running. Signed-off-by: Klaus Smolin <smolin@de.ibm.com> Signed-off-by: Jacob Emery <jacob.emery@ibm.com> Co-authored-by: Jacob Emery <jacob.emery@ibm.com> Signed-off-by: Amadeus Podvratnik <pod@de.ibm.com>
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The openshift-installer requires up to 60 min to complete. You need to check manually if the install process started sucessfully or you simply wait 60 min for the results. This patch monitors the 'node-bootstrapper' request. Usually such request is raised within 6 min. If not, then this is considered as an error and the ansible playbook script exits. The openshift-installer process is not aborted! It is still running. Signed-off-by: Klaus Smolin <smolin@de.ibm.com> Signed-off-by: Jacob Emery <jacob.emery@ibm.com> Co-authored-by: Jacob Emery <jacob.emery@ibm.com>
The openshift-installer requires up to 60 min to complete. You need to check manually if the install process started sucessfully or you simply wait 60 min for the results.
This patch monitors the 'node-bootstrapper' request. Usually such request is raised within 6 min. If not, then this is considered as an error and the ansible playbook script exits.
The openshift-installer process is not aborted! It is still running.
Signed-off-by: Klaus Smolin smolin@de.ibm.com