fix: Change ftp server to file server #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name 'FTP server' is confusing since the KVM host is now capable of hosting and serving necessary files via http only. Update the docs and variables to represent this change. Also enable using either ftp or http to serve config files for the bastion. FTP is still the only option for booting the KVM hosts, and HTTP will still be installed and used on the bastion as it is required. But with these changes, someone using a pre-existing KVM host can use only HTTP. And someone using an FTP server for the booting of the KVM host can use that same FTP server to boot the bastion. Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
|
Received feedback from users that this was confusing to them, decided to tackle it today. Tested a highly-available deployment (3 LPARs, macvtap) with env.file_server.protocol as 'ftp' and entire test run as 'http'. |
smolin-de
suggested changes
Feb 22, 2023
smolin-de
reviewed
Feb 22, 2023
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
jacobemery
changed the title
Ah, you are correct, my apologies! I've updated the description. Looks like none of the code has to change, but that was a lapse in my understanding, thanks! Everything else look ok @smolin-de ? |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jacobemery
added a commit
that referenced
this pull request
Dec 20, 2023
Related to Issue #96 The name 'FTP server' is confusing since the KVM host is now capable of hosting and serving necessary files via http only. Update the docs and variables to represent this change. Also, enable using either ftp or http to serve config files for the bastion. FTP is still the only option for booting the KVM hosts, as that is the only option for the HMC to network boot from. And HTTP will still be installed and used on the bastion as it is required. But with these changes, someone using a pre-existing KVM host and NAT-based networking can use only HTTP if they'd like. And someone using an FTP server for booting of the KVM host(s) can use that same FTP server to boot the bastion. --------- Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #96
The name 'FTP server' is confusing since the KVM host is now capable of hosting and serving necessary files via http only. Update the docs and variables to represent this change.
Also, enable using either ftp or http to serve config files for the bastion. FTP is still the only option for booting the KVM hosts, as that is the only option for the HMC to network boot from. And HTTP will still be installed and used on the bastion as it is required. But with these changes, someone using a pre-existing KVM host and NAT-based networking can use only HTTP if they'd like. And someone using an FTP server for booting of the KVM host(s) can use that same FTP server to boot the bastion.