-
Notifications
You must be signed in to change notification settings - Fork 34
csm: fix client-to-daemon large message protocol #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes regression, as well as the unit tests described in #96
For the records:
|
With the latest few commits, the limit slightly shifts to 16777143. |
@lasch Ran regression on the new code, passed again. Additionally the unit tests are still behaving as expected |
We noticed that the large-msg protocol for messages from clients to daemon was not functioning as expected. It caused the daemon to receive several invalid messages and the client to get disconnected.
This PR fixes the protocol.
@fpizzano This might be a candidate for a hotfix since it might cause trouble for anything that tries to send CSM API requests larger than 128k.
Will open an issue to add a regression test.