POST requests without an ID cause a NPE with fhir-smart enabled #3576
Comments
lmsurpre
added a commit
that referenced
this issue
Apr 19, 2022
Now that our persistence layer requires resources to have proper metadata prior to calling create/update/delete, I thought that resources will always have an id before we call the persistence interceptors. However, it turns out that we call the beforeCreate from the REST layer BEFORE setting this metadata on the resource. After a brief discussion, we decided to leave that as-is and update the interceptor to allow a null id. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 20, 2022
issue #3576 - remove unnecessary guard against null resourceId
lmsurpre
added a commit
that referenced
this issue
Apr 20, 2022
prior to calling doCreate on the interceptors Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 21, 2022
issue #3576 - remove Resource.id passed via POST
|
verified that this now does not give a NPE and allows you to create a Patient compartment reource that is linked to the patient you have access too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
A
POSTrequest for a new resource (as tested,Observation) without anidcauses aNullPointerExceptionbecause of thisObjects.requireNonNullcheck infhir-smart. When anidis present, it is ignored in accordance to the specifications and the resource is created as usual with a server generated ID.Environment
4.11.0, using the Docker imagedocker.io/ibmcom/ibm-fhir-serverwithfhir-smartenabled.To Reproduce
Perform a create by sending a
POSTrequest with a new resource to an endpoint without anidpresent in the request body. This will cause aNullPointerExceptionand a500 Internal Server Errorresponse without the resource being created.Expected behavior
A
201 Createdresponse for POST requests without anidkey present, and the resource being created with an ID generated by the server.Additional context
Request headers:
Request JSON:
{ "resourceType":"Observation", "status":"final", "effectiveDateTime":"2022-04-14T12:38:18+02:00", "subject":{ "reference":"Patient/001467ad114848ad824fc6878ef9b267" }, "code":{ "coding":[ { "code":"29463-7", "system":"http://loinc.org" } ] }, "category":[ { "coding":[ { "code":"vital-signs", "display":"Vital Signs", "system":"http://hl7.org/fhir/observation-category" } ] } ], "note":[ ], "valueQuantity":{ "unit":"kg", "system":"http://unitsofmeasure.org", "value":123 }, "component":[ ] }Logs:
The text was updated successfully, but these errors were encountered: