issue #3576 - remove unnecessary guard against null resourceId #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that our persistence layer requires resources to have proper metadata prior to calling create/update/delete, I thought that resources will always have an id before we call the persistence interceptors. However, it turns out that we call the beforeCreate from the REST layer BEFORE setting this metadata on the resource. After a brief discussion, we decided to leave that as-is and update the interceptor to allow a null id. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
changed the title
lmsurpre
commented
Apr 19, 2022
| @@ -195,7 +195,7 @@ public FHIRRestHelper(FHIRPersistence persistence, SearchHelper searchHelper) { | |||
|
|
|||
| @Override | |||
| public FHIRRestOperationResponse doCreate(String type, Resource resource, String ifNoneExist, | |||
| boolean doValidation) throws Exception { | |||
| boolean doValidation) throws Exception { | |||
There was a problem hiding this comment.
unrelated formatting changes i had in my workspace
punktilious
reviewed
Apr 20, 2022
| @@ -954,7 +957,7 @@ private boolean isInCompartment(String resourceType, String resourceId, Resource | |||
| for (String searchParmCode : inclusionCriteria) { | |||
| try { | |||
| SearchParameter inclusionParm = searchHelper.getSearchParameter(resourceType, searchParmCode); | |||
| if (inclusionParm != null & inclusionParm.getExpression() != null) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our persistence layer requires resources to have proper
metadata (id, versionId, and lastUpdated) prior to calling create/update/delete, I thought that resources
will always have an id before we call the persistence interceptors.
However, it turns out that we call the beforeCreate from the REST layer
BEFORE setting this metadata on the resource.
After a brief discussion, we decided to leave that as-is and update the
interceptor to allow a null resourceId.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com