DropSchema related changes for issue #1595 #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only a partial fix. More work needs to happen for drop-schema to work on PostgreSQL. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Also added try/catch for dropping undefined indexes Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112
reviewed
Oct 21, 2020
...atabase-utils/src/main/java/com/ibm/fhir/database/utils/postgresql/PostgreSqlTranslator.java
Show resolved
Hide resolved
prb112
reviewed
Oct 21, 2020
prb112
reviewed
Oct 21, 2020
prb112
reviewed
Oct 21, 2020
prb112
suggested changes
Oct 21, 2020
punktilious
approved these changes
Oct 21, 2020
prb112
approved these changes
Oct 21, 2020
Permission objects are not used in our use of PostgreSQL Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
--drop-schemawas used without--drop-schema-fhir,--drop-schema-oauth, or--drop-schema-jbatchthen it completed with success without actually doing anything.I think what happened is that we were debating two different options for these args:
A. passing some kind of argument to
--drop-schema, so it might be like--drop-schema fhiror--drop-schema oauth jbatch; orB. using explicit flags for dropping the fhir, schema, or oauth tables, so usage would be like
--drop-schema-fhir --drop-schema-oauthBut somehow we ended up with a combination of the two which I hope we can all agree is not very good.
This pull request modifies the current behavior and turns it into option B, removing support for the
--drop-schemaaction.Note: this PR does not actually address issue #1595 ...it only reworks the user experience of the cli so that others can avoid the error that I made initially.