Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move constants values to be configurable in helm chart #54

Closed
Tomcli opened this issue Apr 4, 2018 · 1 comment
Closed

Move constants values to be configurable in helm chart #54

Tomcli opened this issue Apr 4, 2018 · 1 comment
Assignees
@Tomcli
Labels
enhancement New feature or request

Comments

@Tomcli
Copy link
Contributor

Tomcli commented Apr 4, 2018

For best practice, we shouldn't have some of the resource constants hard coded in the code base. This will cause issue such as #13 hard to fix. Also, making some of these constants configurable in helm chart can allow users deploy FfDL based on their Kubernetes Cluster size.
@Tomcli Tomcli added the enhancement New feature or request label Apr 4, 2018
@Tomcli Tomcli self-assigned this Apr 4, 2018
@Tomcli Tomcli mentioned this issue Apr 11, 2018
Closed
@Tomcli
Copy link
Contributor Author

Tomcli commented Aug 1, 2018

Closed with 0.1 release

@Tomcli Tomcli closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tomcli Tomcli

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make helper pods spec, namespaces, and other features configurable. IBM/FfDL
1 participant
@Tomcli