Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Make helper pods spec, namespaces, and other features configurable. #65

Closed
Tomcli wants to merge 5 commits intomasterfrom
variable-patch
Closed

Make helper pods spec, namespaces, and other features configurable. #65
Tomcli wants to merge 5 commits intomasterfrom
variable-patch

Conversation

@Tomcli
Copy link
Contributor

@Tomcli Tomcli commented Apr 11, 2018

This PR allows users to configure their helper pods specs and namespaces using the helm values.yml. The default namespace remains as default, but this will help us migrate to a dedicated namespaces in the future.

This PR also allows users to pick how to consume GPU resources via the values.yml, so they don't have to pull or build a different docker image for different environments.

All the major documentations are available at the developer-guide.md. This gives more options and flexibility for developers to try FfDL on different environments with different capability.

This closes #54, closes #55, and closes #56.

Signed-off-by: Tommy Li tommy.chaoping.li@ibm.com

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@Tomcli Tomcli added the enhancement New feature or request label Apr 11, 2018
@Tomcli
Copy link
Contributor Author

Tomcli commented Jul 2, 2018

Moved to #110

@Tomcli Tomcli closed this Jul 2, 2018
@Tomcli Tomcli deleted the variable-patch branch July 2, 2018 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build error Deploy FfDL in a dedicated namespace Move constants values to be configurable in helm chart

1 participant