-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request param descriptions and update Swagger models help text #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing label
to class label
is an interesting choice, but I'm fine with it. LGTM
Input: Output: I am not sure the though is good for this. If not, please ignore it. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Description/help text that forms a valid sentence should end with a period. (see help for detection_box) Not sure if there is a standard though.
LGTM |
@xwu0226 ok let's assign someone to roll similar changes out across models. |
Status badge and link to long running instance of the web app
Added help text describing request params for
model/predict
in more detail.Existing Swagger UI:
Now:
Also updated the description text for various fields in the Swagger models for responses.