Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build support #58

Merged
merged 5 commits into from
Oct 30, 2020
Merged

Windows build support #58

merged 5 commits into from
Oct 30, 2020

Conversation

filemaster
Copy link
Member

@filemaster filemaster commented Oct 30, 2020 •
edited

Related issues

#12 Add Windows Build Support

Description

Project requires some small changes to be used on Windows machine. Main changes were related with the compiler settings.

Details

  • Update FindBLAS adding some extra paths for Windows.
  • Fix some ambiguos calls to make_unique call from the RPUCuda.
  • Setup CMake to use the right flags for Windows environments.
  • Add Windows section to the install documentation.

diego-plan9
diego-plan9 approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@diego-plan9 diego-plan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort @filemaster !

@diego-plan9 diego-plan9 merged commit a158e27 into IBM:master Oct 30, 2020
@diego-plan9 diego-plan9 mentioned this pull request Oct 30, 2020
Open
@filemaster filemaster mentioned this pull request Nov 6, 2020
Merged
@filemaster filemaster deleted the Windows-support branch November 10, 2020 10:46
@diego-plan9 diego-plan9 mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diego-plan9 diego-plan9 diego-plan9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filemaster @diego-plan9