Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

Add Restkit to project configuration #43

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Add Restkit to project configuration #43

merged 3 commits into from
Jan 14, 2019

Conversation

christiancompton
Copy link
Collaborator

This PR addresses some problems with the project.

  • When upgrading to the Watson 1.0 SDK, RestKit was added as its own framework - this adds it automatically to the .xcproj
  • Cleaning of log/print statements
  • Swift 4.2 conversion

@christiancompton
Copy link
Collaborator Author

christiancompton commented Jan 11, 2019

I'm seeing the app crash shortly after starting - I'll try to investigate the threading, but that may be out of scope for this PR.

@stevemar
Copy link

This is a good start, thanks for letting us know about the legacy api_key authentication being removed. If you can't figure out why the app crashes we'll re-evaluate if it's an issue with this change or if it's happening in master.

@christiancompton
Copy link
Collaborator Author

@stevemart This crash is happening in master. Back in April, I was attributing this error to the old processor on the iPhone 6S I was using, but I have access to an iPhone X now, and was able to replicate. Can you have someone investigate this?

@stevemar
Copy link

@christiancompton thanks for confirming it happens on master.

@sanjeevghimire can you look into this?

@christiancompton think we should merge your changes anyway or will that just make things harder to debug 🤔 ?

@christiancompton
Copy link
Collaborator Author

I am finishing some of the error logging improvements still - should be done shortly.

@christiancompton christiancompton changed the title [WIP] Add Restkit to project configuration Add Restkit to project configuration Jan 14, 2019
Copy link

@stevemar stevemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@stevemar stevemar merged commit 187d391 into master Jan 14, 2019
@stevemar stevemar deleted the testing branch January 14, 2019 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants