Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for registry flag for pnpm #293

Merged
merged 7 commits into from
Dec 30, 2022
Merged

Conversation

DiogoVCS
Copy link
Contributor

Related to this issue: #292.

Diogo Soares (CTW) added 2 commits December 24, 2022 16:44
Signed-off-by: Diogo Soares (CTW) <Diogo.VD.Soares@ctw.bmwgroup.com>
Signed-off-by: Diogo Soares (CTW) <Diogo.VD.Soares@ctw.bmwgroup.com>
lib/pnpm-auditer.ts Outdated Show resolved Hide resolved
Diogo Soares (CTW) added 2 commits December 26, 2022 09:25
…sion unsuporting registry flag

Signed-off-by: Diogo Soares (CTW) <Diogo.VD.Soares@ctw.bmwgroup.com>
Signed-off-by: Diogo Soares (CTW) <Diogo.VD.Soares@ctw.bmwgroup.com>
Copy link
Member

@quinnturner quinnturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change suggested for performance. Otherwise, LGTM! No extra tests needed; the code is solid :)

lib/pnpm-auditer.ts Show resolved Hide resolved
Signed-off-by: Diogo Soares (CTW) <Diogo.VD.Soares@ctw.bmwgroup.com>
lib/pnpm-auditer.ts Outdated Show resolved Hide resolved
lib/pnpm-auditer.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants