fix(Selection): prevent selection from reselecting when deselecting

[scottdickerson]

Prevent selection from reselecting when deselecting

Closes IBM/carbon-components-react#1291

{{short description}}

Changelog

New

• {{new thing}}

Changed

• Fix the selection criteria to actually check the id when determining reselection, this prevents the need to pass the exact in-memory item to the initialSelectedItems list.

Removed

• {{removed thing}}

[scottdickerson]

If you remove the Selection change and go to the MultiSelect storybook for multiple items with initial Values selected, you can see the bug when you deselect the existing selection (see bug #1291). Then putting back in the Selection change will fix it.

[asudoh]

LGTM basically, but .findIndex() is not supported by IE11 or in our polyfills list. Given updating polyfills list causes a breaking change, do you want to try an approach without .findIndex()? Thanks!

[joshblack]

Love the strategy here, but when it comes to API for initialSelectedItems I think it'd be nice if we supported an array of ids (strings) or an array of indices (numbers) that we would check for in the handleOnItemChange. In addition, could we add a test for this additional functionality for Selection?

[scottdickerson]

yes I can do that, thanks for the suggestions. @joshblack and @asudoh.

[scottdickerson]

this has been superceded by this track: #1314