This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(modal): set initial focus and conditionally render focus trap #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit 939a89b https://deploy-preview-2163--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit a4cfcb8 https://deploy-preview-2163--carbon-components-react.netlify.com |
asudoh
approved these changes
Apr 5, 2019
asmith-IBM
pushed a commit
to asmith-IBM/carbon-components-react
that referenced
this pull request
Apr 18, 2019
…rbon-design-system#2163) * fix(Modal): get focus behavior in sync with/without focus-trap * fix(modal): remove unused focus-trap, createFocusTrap * chore(modal): update snapshots
asudoh
pushed a commit
that referenced
this pull request
Apr 20, 2019
…2237) * fix(Modal): fix NPE at onTransitionEnd (#2141) Caused by `onTransitionEnd` on a child element in modal, presumably when modal node ref hasn't been ready yet. Fixes #2140. * fix(modal): set initial focus and conditionally render focus trap (#2163) * fix(Modal): get focus behavior in sync with/without focus-trap * fix(modal): remove unused focus-trap, createFocusTrap * chore(modal): update snapshots
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2131
This is mostly @asudoh 's work, but I got it over the finish line 😉
These changes set an initial focus for the focus-trap and conditionally render the
<FocusTrap>element to avoid crashes when there is no focusable elements on the modal.