This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(tooltip): handle esc keydown event #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit 78c922b https://deploy-preview-2164--carbon-components-react.netlify.com |
asudoh
approved these changes
Apr 5, 2019
vpicone
approved these changes
Apr 8, 2019
asudoh
reviewed
Apr 8, 2019
src/components/Tooltip/Tooltip.js
Outdated
| @@ -374,6 +374,11 @@ class Tooltip extends Component { | |||
| handleKeyPress = evt => { | |||
| const key = evt.key || evt.which; | |||
|
|
|||
| if (key === 'Escape' || key === 27) { | |||
There was a problem hiding this comment.
Suggested change
| if (key === 'Escape' || key === 27) { | |
| if (key === 'Escape' || key === 'Esc' || key === 27) { |
Talking with @vpicone revealed that evt.key yields Esc in IE and looks that we should cover that.
There was a problem hiding this comment.
would we want to also update and use these helper functions https://github.com/IBM/carbon-components-react/blob/master/src/tools/key.js?
There was a problem hiding this comment.
@emyarod Good point - I think it makes sense to me.
dakahn
added
status: WIP 👩💻
and removed
status: one more review 👀
status: ready for review 👀
labels
…onents-react into fix/2076-tooltip-a11y
|
Thanks @dakahn for the update and my apologies for being late on this - Updated code basically looks good to me, could you please look at the test failure? |
|
The updated code LGTM 👍 - Thanks @dakahn! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a check in the
handleKeyPressmethod that closes the tooltip if escape is pressed.ref #2076
to test
open the tool tip and press escape. the tooltip should close.