Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

fix(DataTableSkeleton): use new classnames #2200

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Apr 11, 2019

closes #2198

@netlify
Copy link

netlify bot commented Apr 11, 2019

Deploy preview for carbon-components-react ready!

Built with commit 63646d4

https://deploy-preview-2200--carbon-components-react.netlify.com

Copy link
Contributor

@jendowns jendowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vpicone! Just one question -- are there any contingencies for v9? (where that -v2 suffix might still apply? given that the styles are feature-flagged?)

Copy link
Contributor

@jendowns jendowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vpicone! Just one question -- are their any contingencies for pre-v10 so that the class name could still have the -v2 suffix for those earlier versions? (given that the styles are feature-flagged)

@vpicone
Copy link
Contributor Author

vpicone commented Apr 11, 2019

@jendowns As we start removing feature flags, more and more v9 stuff will break. Unfortunately we can't support using versions of carbon-components v9 with carbon-react v7 going forward.

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @vpicone!

@asudoh asudoh merged commit 2351b03 into carbon-design-system:master Apr 12, 2019
@vpicone vpicone mentioned this pull request Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants