This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(Icon): removes description default value #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit a23a3b9 https://deploy-preview-2235--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 2f2325e https://deploy-preview-2235--carbon-components-react.netlify.com |
emyarod
approved these changes
Apr 18, 2019
asudoh
approved these changes
Apr 18, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Hey you all ✨Hope you are doing all fine and coding happily!
Closes https://github.com/IBM/carbon-components-react/issues/2230
When the Icon component is being used without the
descriptionproperty the default is being assigned todescription. The default value at the moment isProvide a description that will be used as the title. This default description generates an invalid (from an a11y perspective) aria-label attribute value in the HTML, which can cause confusion to the end user. This leads to a false negative in DAP (no reported violation).Changelog
Removed
Removed the following property from the Icon component.
descripton: Provide a description that will be used as the titlePlease dont hesitate to raise questions! Peace out!