This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(Tooltip): adds esc listener #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit 2102a0a https://deploy-preview-2248--carbon-components-react.netlify.com |
asudoh
reviewed
Apr 19, 2019
| @@ -266,6 +266,8 @@ class Tooltip extends Component { | |||
| requestAnimationFrame(() => { | |||
| this.getTriggerPosition(); | |||
| }); | |||
|
|
|||
| document.addEventListener('keydown', this.handleEscKeyPress, false); | |||
There was a problem hiding this comment.
Please clean-up this event listener on un-mount.
There was a problem hiding this comment.
thanks for the quick review! Keep it up!
dakahn
reviewed
Apr 19, 2019
asudoh
approved these changes
Apr 20, 2019
|
@asudoh is something holding us back here? |
|
@paschalidi Sorry for being late! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃憢 !
Closes https://github.com/IBM/carbon-components-react/issues/1764
Adds event listener so that Esc key closes
Tooltipwhen state isopen.Changelog
New
Adds event listener so that Esc key closes
Tooltipwhen state isopen.