This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(Loading): adds aria-label and description property to component #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit 4beb6dc https://deploy-preview-2252--carbon-components-react.netlify.com |
dakahn
approved these changes
Apr 22, 2019
asudoh
approved these changes
Apr 22, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃審 馃憢 hello you all
Closes https://github.com/IBM/carbon-components-react/issues/2191
Adds property
descriptionwhich is added asaria-labelto the loading indicators (both inline and normal). This way VO will now announce the loading state.Tested locally with iOS and VO. Reader will now announce that a loader is on the screen.
Changelog
New
Property
descriptionwhich is added asaria-labelto theLoadingcomponent.