This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(Pagination): pageInputDisabled won't append disabled class to buttons #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit 27b92b3 https://deploy-preview-2278--carbon-components-react.netlify.com |
asudoh
approved these changes
Apr 30, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IBM/carbon-components-react#2264
Pagination component with
pageInputDisabled: trueprop would display forward and backward buttons as disabled, while they'd still work when clicking.This PR disables check for
pageInputDisabledso the buttons' styling is not affected by it.disabledprop disables next/previous page buttons so it can be used in parallel withpageInputDisabledif that functionality is needed.