Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

ci: switch from Travis to CircleCI #1551

Merged

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Nov 9, 2018

Closes IBM/carbon-components-react#1550

Switch to CircleCI from TravisCI.

Changelog

New

  • .circleci folder, includes CircleCI config and manifest files

Changed

  • README.md update status badge

Removed

  • .travis.yml

@joshblack joshblack changed the title WIP ci: switch from Travis to CircleCI ci: switch from Travis to CircleCI Nov 9, 2018
@joshblack joshblack requested a review from a team November 9, 2018 22:06
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @joshblack!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! ✨ LGTM!

@emyarod
Copy link
Member

emyarod commented Nov 12, 2018

it looks like CircleCI is having trouble building feature branches (e.g. #1537, failing on the npm install command. There's also a warning notification to upgrade from CircleCI 1.0 to 2.0

@joshblack
Copy link
Contributor Author

@emyarod it won't have the correct build for other branches until we merge it in 👍

@emyarod
Copy link
Member

emyarod commented Nov 12, 2018

@joshblack oops my fault I didn't even realize it wasn't merged yet 😄

@joshblack joshblack merged commit f860286 into carbon-design-system:master Nov 12, 2018
@joshblack joshblack deleted the 1550-update-to-circle branch November 12, 2018 15:24
@carbon-bot
Copy link

🎉 This PR is included in version 6.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants