Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-select): add styles for filterable multiselect inputs #2265

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Apr 4, 2019

Closes #2264

This PR adds styles for the input fields in the filterable multi select component

Changelog

New

  • filterable multi select exposed in docs

Changed

  • adjust left padding of filterable multi select input field. Note: this value will need to be adjusted by the consumer based on the number of selections in the component. i.e. the input field needs adjusted padding to account for the width of the number in <ListBox.Selection>

Testing / Reviewing

Ensure that the filterable multiselect is displaying properly

@netlify
Copy link

netlify bot commented Apr 4, 2019

Deploy preview for the-carbon-components ready!

Built with commit 701c481

https://deploy-preview-2265--the-carbon-components.netlify.com

Copy link
Member Author

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the new class is approved, the migration doc will need updates as well

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There needs to be 8px padding from the left of the tag and to the right of the tag (before text)
    Screen Shot 2019-04-04 at 2 46 04 PM

@emyarod emyarod requested a review from laurenmrice April 4, 2019 20:13
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod!

@asudoh asudoh merged commit b457d9a into carbon-design-system:master Apr 4, 2019
@emyarod emyarod deleted the 2264-filterable-multiselects-with-items-selected-have-broken-styles branch April 5, 2019 14:34
@vpicone vpicone mentioned this pull request Apr 8, 2019
@joshblack joshblack mentioned this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants