fix(combo-box): fixes multiple border issue on exp combo-box #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonjoseph
approved these changes
Nov 2, 2018
|
🎉 This PR is included in version 9.44.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…event clicks and keyboard events bubbling up through the dom (carbon-design-system#1384) * Moved onClick/onKeyDown handlers to correct element (previously only the click handler was firing). Added stopPropagation to prevent the events bubbling up (e.g. when a tooltip is inside a button) * Fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs issues found in #1381
Removes double border on experimental
MultiSelectandComboBoxChangelog
Changed
combo-box.scssbox-shadowtoborder-bottomTesting / Reviewing
Ensure only one border shows up on experimental
MultiSelectandComboBox