Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove httpmime dependency and upgraded to httpclient5 #80

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

sharmakh
Copy link

@sharmakh sharmakh commented Jun 6, 2024

Remove httpmime dependency and upgraded to httpclient5

Resolves #77

Signed-off-by: Khushboo110597@ibm.com
@sharmakh sharmakh requested review from KyeMaloy97 and davenice and removed request for KyeMaloy97 June 6, 2024 10:00
Signed-off-by: Khushboo110597@ibm.com
@davenice
Copy link
Contributor

davenice commented Jun 6, 2024

This looks good to me. I'll approve, I think @sharmakh had a couple more tests she wants to run before we merge it though, so I'll let @sharmakh merge it when she's ready.

pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Khushboo110597@ibm.com
pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Khushboo110597@ibm.com
@sharmakh
Copy link
Author

@davenice i have tested it we can go ahead with merging this.

@davenice davenice merged commit 32f85b4 into main Jun 10, 2024
6 checks passed
@davenice davenice deleted the remove_dependency branch June 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to httpmime bundled with httpclient5
2 participants