Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to see testing coverage #12

Merged
merged 37 commits into from
Aug 9, 2021
Merged

Conversation

michaelhilborn
Copy link
Contributor

No description provided.

Copy link
Member

@Pseusco Pseusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the HEAD sections of this PR

Pseusco
Pseusco previously approved these changes Jul 23, 2021
Copy link
Contributor

@akuljos akuljos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think, though, that for the DNS/Edge Function tests, it might be a good idea to have additional unit tests for if the user inputs 'n', just to ensure that the resources aren't being deleted when that option is specified.

@michaelhilborn
Copy link
Contributor Author

Looks good! I think, though, that for the DNS/Edge Function tests, it might be a good idea to have additional unit tests for if the user inputs 'n', just to ensure that the resources aren't being deleted when that option is specified.

Changes made to address this in commit 9bf54a0

@akuljos
Copy link
Contributor

akuljos commented Jul 28, 2021

The failed Travis test is due to some inconsistencies between the master branch and testing branch in regards to a positional variable in the initialization of the SecretCertificateCreator object within my testing file. When I have that positional variable, it errors out due to the lack of that positional variable in the testing branch; when I don't have that positional variable, it errors out due to the presence of the positional variable in the master branch. This change shouldn't affect our functionality in any way and it should be resolved once the pull request is merged.

@akuljos akuljos force-pushed the coverage-tests branch 8 times, most recently from 42bbbd4 to cf5c4ba Compare August 2, 2021 15:40
Pseusco
Pseusco previously approved these changes Aug 4, 2021
@michaelhilborn michaelhilborn merged commit 71c2a83 into master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants