Delete ingress #33
Merged
Delete ingress #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuljos
previously approved these changes
Aug 6, 2021
Pseusco
suggested changes
Aug 9, 2021
There was a problem hiding this comment.
There are a couple commented-out sections in iks.py that look like they were only commented out for testing, so they should probably be uncommented. Eventually we will need to update the README to represent the new argument for the delete function, but that doesn't necessarily need to be done now.
src/iks/iks.py
Outdated
| delete_dns = DeleteDNS(UserInfo.crn, UserInfo.zone_id, UserInfo.api_endpoint, UserInfo.cis_domain) | ||
| delete_dns.delete_dns() | ||
| ''' |
There was a problem hiding this comment.
We shouldn't comment out the DNS record deletion. Our delete function should still be able to delete the DNS records
Pseusco
approved these changes
Aug 11, 2021
akuljos
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created function to delete ingress file