Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenController cache memory too large on OpenShift 4.4 (90MB) #199

Open
JohnStarich opened this issue Sep 18, 2020 · 0 comments
Open

TokenController cache memory too large on OpenShift 4.4 (90MB) #199

JohnStarich opened this issue Sep 18, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@JohnStarich
Copy link
Member

In my relatively fresh OpenShift 4.4 cluster, there are 935 secrets.
The TokenController's watcher is pulling all of them into a cache, which inflates memory usage unnecessarily from 15 MB to 103 M (it eventually decreases to 44M).

I see 2 options:

Since this is an order of magnitude difference, I think we'll need to opt for a no-op cache in the interim. An example using controller-runtime v0.6:

Watches(source.NewKindWithCache(&corev1.Secret{}, <cache>), &handler.EnqueueRequestForObject{}).
@JohnStarich JohnStarich added the bug Something isn't working label Sep 18, 2020
JohnStarich added a commit that referenced this issue Sep 18, 2020
@JohnStarich
Raise memory limit for OpenShift: #199
fc371b9 
Signed-off-by: John Starich <johnstarich@johnstarich.com>
@JohnStarich JohnStarich mentioned this issue Sep 18, 2020
Merged
JohnStarich added a commit that referenced this issue Sep 18, 2020
@JohnStarich
Fix OLM data & formatting issues (#200)
dff8b02 
Fixes OLM metadata so it will install properly from Operator Hub for v0.2+. Adds make tasks to assists OLM testing.
Bumps the memory limit to mitigate an OOMKilled issue when running in OpenShift 4.4 (i.e. lots of built-in secrets). Opened #199 to look into it further.

Also update TokenController to skip processing any secret not using the well-known names. e.g. `secret-ibm-cloud-operator` `<namespace>-secret-ibm-cloud-operator`
@JohnStarich JohnStarich mentioned this issue Sep 22, 2020
Merged
artberger pushed a commit that referenced this issue Sep 23, 2020
@JohnStarich
Fix OLM data & formatting issues (#200)
bca25d6 
Fixes OLM metadata so it will install properly from Operator Hub for v0.2+. Adds make tasks to assists OLM testing.
Bumps the memory limit to mitigate an OOMKilled issue when running in OpenShift 4.4 (i.e. lots of built-in secrets). Opened #199 to look into it further.

Also update TokenController to skip processing any secret not using the well-known names. e.g. `secret-ibm-cloud-operator` `<namespace>-secret-ibm-cloud-operator`

Signed-off-by: Art Berger <arthur.berger@ibm.com>
@JohnStarich JohnStarich mentioned this issue Sep 17, 2021
Closed
@JohnStarich JohnStarich mentioned this issue Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohnStarich