Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding en to avoid error with small sentences and calling get_result before processing result #21

Closed
wants to merge 4 commits into from

Conversation

upkarlidder
Copy link
Member

No description provided.

@upkarlidder
Copy link
Member Author

Not sure why it added commits closed in previous PR 👎. Should I create another PR ?

sanjeevghimire
sanjeevghimire approved these changes Jan 29, 2019
Copy link
Contributor

@sanjeevghimire sanjeevghimire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will test the branch out before merge.

@sanjeevghimire
Copy link
Contributor

sanjeevghimire commented Jan 29, 2019

@lidderupk I do remember removing the changes that you have currently in the PR as it was not working with the version of Watson SDK available in the cloud function. If this is working for you, I will test your branch before the merge

@upkarlidder
Copy link
Member Author

upkarlidder commented Jan 29, 2019

@sanjeevghimire, I am using the latest. I got the NLU URL from the service dashboard. If I just clone the repo, change the param.json file and run it, I get the errors. Are you able to reproduce ? I also created two issues with more details of the errors I see.

@sanjeevghimire
Copy link
Contributor

@lidderupk did you test this locally or on the cloud? I am going to test it on the cloud and see if I can reproduce the issues.

@upkarlidder
Copy link
Member Author

upkarlidder commented Jan 29, 2019

@sanjeevghimire, I tested on IBM Cloud Functions using the commands listed in the repo. I created the NLU and visual recognition services. Visual Recognition worked fine. I got the errors in the NLU part.

@sanjeevghimire
Copy link
Contributor

#23 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants