-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding en to avoid error with small sentences and calling get_result before processing result #21
Conversation
Not sure why it added commits closed in previous PR 👎. Should I create another PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will test the branch out before merge.
@lidderupk I do remember removing the changes that you have currently in the PR as it was not working with the version of Watson SDK available in the cloud function. If this is working for you, I will test your branch before the merge |
@sanjeevghimire, I am using the latest. I got the NLU URL from the service dashboard. If I just clone the repo, change the param.json file and run it, I get the errors. Are you able to reproduce ? I also created two issues with more details of the errors I see. |
@lidderupk did you test this locally or on the cloud? I am going to test it on the cloud and see if I can reproduce the issues. |
@sanjeevghimire, I tested on IBM Cloud Functions using the commands listed in the repo. I created the NLU and visual recognition services. Visual Recognition worked fine. I got the errors in the NLU part. |
#23 fixes this. |
No description provided.