This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Deploy to cloud bug fix #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sanjeevghimire can you update the commit message to describe how you fixed the bug? And also include the text |
added 2 commits
September 12, 2018 21:23
* Since tsc is used as dev dependency, do the build locally as npm install wouldn't install dev dependency in IBM cloud * copy the package.json to the dist directory * ibm cloud cf push crm-server
…cial-crm into deploy-to-cloud-bug-fix
|
@stevemart commit message amended. |
scottdangelo
approved these changes
Sep 13, 2018
|
OK, I think the message is in one of the commits. |
|
This PR fixes/closes #55 . The issue is to do with dev dependencies not installed when pushing to cloudfoundry using The project use Typescript. Node.js doesn't understand typescript directly, so it has to be compiled into JavaScript first using The solution was to build the project before you push to IBM cloud. The steps are:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes: #55 . The issue is to do with dev dependencies not installed when pushing to cloudfoundry using ibmcloud cli.
The project use Typescript. Node.js doesn't understand typescript directly, so it has to be compiled into JavaScript first using tsc command and then run the built project. Since typescript is added as a devDependency in package.json, relying on Cloud Foundry to install the dependency didn't work.
The solution was to build the project before you push to IBM cloud. The steps are: