Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prefix): make use of -- as a prefix standard #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

diego-codes
Copy link

@diego-codes diego-codes commented Jul 20, 2018

It adds an extra - to the prefixing of class name so it is consistent with Carbon's prefixing standards. This is so that the $prefix value is respected in the building of sass code for Carbon users.

Copy link
Contributor

@seejamescode seejamescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change that I can’t really find in the BEM website.

I do understand why it is important to existing Carbon users. Would it be possible to edit the prefix in the IBM grid repo to ibm- to get this extra -?

That would be great because it would accommodate the IBM need without confusing non-IBMers.

@diego-codes
Copy link
Author

Sadly we can’t make that update on the IBM grid package because it would conflict with Carbon’s prefix variable bx.

The class names themselves need to be updated to include -- in them like the rest of Carbon’s Sass. That way a consuming developer can declare their own $prefix and generate class names that are consistent all across.

@seejamescode
Copy link
Contributor

In that case, it sounds like the real fix is changing the prefix variable in Carbon right before the grid is imported and then switching the variable back right afterwards. Would that work?

Otherwise, a major change we need to do is prefix the prefix variable in Gridish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants