Merge pull request #368 from revit13/fix14

Fix set-versions target in kfp/kfp_ray_components.
IBM · Jul 1, 2024 · bc5e60d · bc5e60d
2 parents 0436111 + dbd844b
commit bc5e60d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/kfp/kfp_ray_components/Makefile b/kfp/kfp_ray_components/Makefile
@@ -42,11 +42,8 @@ image: Dockerfile requirements.txt
 .reconcile-requirements:
 	@sed -i.back "s/kfp-data-processing.*:[0-9].*/$(DOCKER_IMAGE_NAME):${DOCKER_IMAGE_VERSION}\"/" ${FILE}
 
-.PHONY: set-versions 
-set-versions::
-
-.PHONE: set-image
-set-image:
+.PHONE: set-versions
+set-versions:
 	@# Help: Update yaml files to build images tagged as version $(KFP_DOCKER_VERSION)
 	@$(MAKE) .reconcile-requirements FILE=createRayClusterComponent.yaml
 	@$(MAKE) .reconcile-requirements FILE=deleteRayClusterComponent.yaml

diff --git a/transforms/.make.workflows b/transforms/.make.workflows
@@ -25,7 +25,7 @@ set-versions:
 
 .PHONY: .workflows.compile-pipeline
 .workflows.compile-pipeline:
-	$(MAKE) -C ${REPOROOT}/kfp/kfp_ray_components set-image
+	$(MAKE) -C ${REPOROOT}/kfp/kfp_ray_components set-versions
 	. ${WORKFLOW_VENV_ACTIVATE} && ${PYTHON} ${WF_NAME}.py
 
 KFP_SHARED_LIB_SRC_FILES := $(shell find ${REPOROOT}/kfp/kfp_support_lib/shared_workflow_support/ \( -name '*.py' -o -name '*.toml' \))
@@ -60,7 +60,7 @@ ${WORKFLOW_VENV_ACTIVATE}: ${REPOROOT}/.make.versions ${REPOROOT}/kfp/kfp_ray_co
 	. ${WORKFLOW_VENV_ACTIVATE};     \
 	pip install -e $(REPOROOT)/kfp/kfp_support_lib/shared_workflow_support; \
 	pip install -e $(REPOROOT)/kfp/kfp_support_lib/$(WORKFLOW_SUPPORT_LIB); \
-	$(MAKE) -C ${REPOROOT}/kfp/kfp_ray_components set-image
+	$(MAKE) -C ${REPOROOT}/kfp/kfp_ray_components set-versions
 	@# Help: Create the virtual environment common to all workflows
 
 .PHONY: .workflows.upload-pipeline