Add helper-functions.sh file to kind/hack folder. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blublinsky
approved these changes
May 13, 2024
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
roytman
requested changes
May 13, 2024
| @@ -15,7 +15,6 @@ The following programs should be manually installed: | |||
| - [Helm](https://helm.sh/docs/intro/install/) 3.10.0 or greater must be installed and configured on your machine. | |||
| - [Kind](https://kind.sigs.k8s.io/docs/user/quick-start/#installation) tool for running local Kubernetes clusters 0.14.0 or newer must be installed on your machine. | |||
| - [Kubectl](https://kubernetes.io/docs/tasks/tools/#kubectl) 1.26 or newer must be installed on your machine. | |||
| - [wget](https://www.gnu.org/software/wget/) 1.21 must be installed on your machine. | |||
There was a problem hiding this comment.
can you also remove wget reference from the latest https://github.com/IBM/data-prep-kit/blob/dev/kfp/doc/simple_transform_pipeline.md version
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
There was a problem hiding this comment.
please add a reference to the original file
Signed-off-by: Revital Sur <eres@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds kind/hack/helper-functions.sh file instead of coping it from kfp-tekton repo.