Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Initial example notebook #80

Closed
wants to merge 4 commits into from
Closed

Conversation

shivdeep-singh-ibm
Copy link
Collaborator

Why are these changes needed?

Added notebook to test transforms locally.

Related issue number (if any).

include ../.make.defaults

#venv:: .transforms.venv .defaults.lib-src-venv
venv:: .defaults.lib-src-venv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I make venv on my mac m1, I get the following, eventually.

$ make venv
...
Installing collected packages: huggingface-hub, tokenizers, transformers
  Attempting uninstall: huggingface-hub
    Found existing installation: huggingface-hub 0.23.0
    Uninstalling huggingface-hub-0.23.0:
      Successfully uninstalled huggingface-hub-0.23.0
  Attempting uninstall: tokenizers
    Found existing installation: tokenizers 0.15.2
    Uninstalling tokenizers-0.15.2:
      Successfully uninstalled tokenizers-0.15.2
  Attempting uninstall: transformers
    Found existing installation: transformers 4.38.2
    Uninstalling transformers-4.38.2:
      Successfully uninstalled transformers-4.38.2
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
datasets 2.17.1 requires huggingface-hub>=0.19.4, but you have huggingface-hub 0.17.3 which is incompatible.
Successfully installed huggingface-hub-0.17.3 tokenizers-0.14.1 transformers-4.35.0
$ 


include ../.make.defaults

#venv:: .transforms.venv .defaults.lib-src-venv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to add a clean target to remove the venv (I think you could use .defaults.clean)

@@ -0,0 +1,20 @@
## Demo Notebook

We can launch a jupyter notebook to try out the library or transforms or to build a usecase.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to either a) tell the user where to get an input data set and where to put it or b) include one in the repo. However, if (b), it should not be large - say not larger than a couple of MB if possible.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in the rebased pull req on another branch #89

Updated Notebook with instructions to get data

@shivdeep-singh-ibm shivdeep-singh-ibm changed the title Initial example notebook [DRAFT] Initial example notebook May 9, 2024
@shivdeep-singh-ibm
Copy link
Collaborator Author

Rebased pull req on another branch #89

@shivdeep-singh-ibm shivdeep-singh-ibm deleted the example-notebook branch May 14, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants