Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name to data prep kit #91

Merged
merged 10 commits into from
May 9, 2024
Merged

Change name to data prep kit #91

merged 10 commits into from
May 9, 2024

Conversation

daw3rd
Copy link
Member

@daw3rd daw3rd commented May 8, 2024 •
edited

Why are these changes needed?

  1. Renamed all references to data-prep-lab[-kfp] to data-prep-toolkit[-kfp] and DPL_ to DPK_ and DPLConfig to DPKConfig.
  2. Readme and other doc references to the repo are changed from data-prep-lab to data-prep-kit. Note they won't work though until the rename of this repo is made to data-prep-kit.
  3. Reset the version numbers of the new wheels
  4. Bumped the minor version number of the published images.

Related issue number (if any).

daw3rd added 2 commits May 8, 2024 16:35
@daw3rd
Replace data-prep-lab etc with data-prep-kit in prep for repo rename.
a5f042d 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd
reset library and image version numbers to accommodate rename
98536a0 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd daw3rd requested review from blublinsky and revit13 May 8, 2024 20:41
daw3rd added 5 commits May 8, 2024 18:50
@daw3rd
Use data-prep-toolkit instead of data-prep-kit as pypi package
97f7cbb 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd
fix version of data-prep-toolkit-kfp in requirements.txt
e2c6b93 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd
Fix docker file wheel reference to data-prep-[tool]kit
c3dab82 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd
fix .make.transform_workflows to use data-prep-toolkit
9024c13 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd
have .make.defaults uninstall data-prep-toolkit
0709598 
Signed-off-by: David Wood <dawood@us.ibm.com>
blublinsky
blublinsky approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@blublinsky blublinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to align versions

.make.versions
PROGLANG_SELECT_VERSION=0.3.0
CODE_QUALITY_VERSION=0.3.0
DOC_QUALITY_VERSION=0.3.0
INGEST_TO_PARQUET_VERSION=0.3.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this 0.3.0? Should we align with the library version and make it 0.1.0?

roytman
roytman approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@revit13
Copy link
Collaborator

revit13 commented May 9, 2024 •
edited

@daw3rd please run make reconcile-requirements under kfp/kfp_ray_components to update image versions in .yaml files.
Also, please update .make.transforms_workflows kfp/transform_workflows (renaming lab with kit) and run make PYTHON=python3.10 build to update the versions in the workflows.

Thanks

daw3rd added 2 commits May 9, 2024 07:44
@daw3rd
Update kfp docker image versions in yamls
360a1ac 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd
Update image versions in all _wf.py files
00c08bf 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd
add data-prep-kit to top level DOCKER_NAMESPACE
cb005d1 
Signed-off-by: David Wood <dawood@us.ibm.com>
@daw3rd daw3rd merged commit 1346e4c into dev May 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roytman roytman roytman approved these changes

@revit13 revit13 revit13 approved these changes

@blublinsky blublinsky blublinsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daw3rd @revit13 @roytman @blublinsky