-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate System Datasets #471
Validate System Datasets #471
Conversation
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about the name of the option flag :)
build.groovy
Outdated
@@ -268,14 +269,15 @@ options: | |||
cli.r(longOpt:'reset', 'Deletes the dependency collections and build result group from the MetadataStore') | |||
cli.v(longOpt:'verbose', 'Flag to turn on script trace') | |||
cli.pv(longOpt:'preview', 'Supplemental flag indicating to run build in preview mode without processing the execute commands') | |||
cli.cds(longOpt:'checkSystemDatasets', 'Optional flag to validate the presense of the defined system datasets. ') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be -csd
as the first letters of "Check System Datasets"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@M-DLB - CSD
is already a known term from CICS. Should we rename the long option to checkDatasets
instead ?
I added the system datasets, because it is really just the system datasets that can be validated in advance and not the additional build datasets that are created during build time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call it checkDatasets
then, so -cd
should be fine :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Or -ivp (Installation Verification Procedure)?
Not limited to check system data sets but validate anything need to be checked.
Could be enhenced / extended by site customisation.
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dennis-behm
This is a new feature helping during the setup phase of zAppBuild to validate that the defined system datasets in
datasets.properties
are correctly configured and present on the system where the build is performed.