Automator party number bugfix #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in ibmfl_cli_automator.run where party numbers are assumed to be one character Signed-off-by: Trevor Smith <trevormax.smith@gmail.com>
|
I deleted my fork and redid the PR so that I could include the signoff in my one commit message, but it's still failing the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in ibmfl_cli_automator.run where party numbers are assumed to be one character, causing crashes for experiments with more than ten parties. Fix simply replaces the last character in the proc_label string with all the characters after party, which should allow for over 100 parties as well. This was tested with up to 20 parties.
Signed-off-by: Trevor Smith trevormax.smith@gmail.com