Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked the READMEs and the way we show the XKCD example. #7

Merged
merged 3 commits into from
Sep 13, 2018
Merged

Reworked the READMEs and the way we show the XKCD example. #7

merged 3 commits into from
Sep 13, 2018

Conversation

zgrossbart
Copy link
Collaborator

@zgrossbart zgrossbart commented Sep 13, 2018 •
edited

This change reworks the README files so we can separate the XKCD sample and add a lot more comments about it.

It also adds more code comments and adds the alt field to our GraphQL query.

@coveralls
Copy link

coveralls commented Sep 13, 2018 •
edited

Pull Request Test Coverage Report for Build 27

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 21: 0.0%
Covered Lines: 282
Relevant Lines: 282
💛 - Coveralls

corycook
corycook approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@corycook corycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

line 45 of the xkcd readme:
"go to the follow URL with" should be following

@zgrossbart zgrossbart merged commit c2b65f2 into master Sep 13, 2018
@zgrossbart zgrossbart deleted the example_refactoring branch September 13, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corycook corycook corycook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zgrossbart @coveralls @corycook