Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tunes api #102

Merged
merged 80 commits into from
Aug 9, 2023
Merged

Update tunes api #102

merged 80 commits into from
Aug 9, 2023

Conversation

moneill0
Copy link
Contributor

@moneill0 moneill0 commented Jul 13, 2023 •
edited by mirianfsilva
Loading

Status

READY

Description

Updated tunes API functions to include the get tune methods and download tune assets functions. Added these function calls to the tune manager. Unit testing still in progress.

Any special notes for your reviewer?

Checklist

  • Automated tests exist
  • Updated Package Requirements (if required, and with maintainers' approval)
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above
  • Link to relevant GitHub issue provided

onkarbhardwaj and others added 30 commits June 22, 2023 15:18
@onkarbhardwaj
Merge pull request #1 from IBM/develop
dd8b702 
Merge upstream
@onkarbhardwaj
Merge branch 'IBM:develop' into develop
1ae83f9
@mirianfsilva @moneill0
init prompt tuning: add examples -files and tunes
b353c3e 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva @moneill0
add schemas
eade6f7 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
init file services
cce1c01 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva @moneill0
init tune services
9d85108 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
feat: tune manager
edda015 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
fix: fixed tunes router
7878761 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
fix: fix merge conflicts
e36af10 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva @moneill0
update imports from file example, update routers
e79844d 
- fix circular import from routers that use service interface (temporary
  solution)
- add routers in the service interface

Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
add tests for files
afd0571 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva @moneill0
update tunes doc-strings
1dcec66 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
request handler changes - add files to httpx POST methods
72eb7ce 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
update files docstrings, improve tests
c80824f 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
fix delete file tests
1cc0390 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva @moneill0
add tunes tests
46a46f2 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva @moneill0
tunes examples updates
ddae508 
- update the imports from tunes examples (all working)
- fix create tune call - update payload to options

Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
add new file-tune example
9e0ddd4 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@onkarbhardwaj
add descriptions and adjust imports
860a869
@moneill0
feat: get tune methods function
1056493 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
fix: fixed get methods endpoint url
ba58545 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
fix pre-commit
b0f4b76 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
tune() and status() methods for model tuning
ca5dc1a
documentation for status() method
1e697ee
@moneill0
feat: download tune assets function
9e7869d 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
unit tests
74fb5d7
@moneill0
test: tune manager pytests
294c1d4 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
improve response helper for tests
26b5373 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@moneill0
fix: fixed get tunes schema check
2500b87 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
Merge pull request #2 from onkarbhardwaj/tune_manager_pytest
268eb76 
Tune manager pytest
@mirianfsilva mirianfsilva changed the base branch from main to develop July 13, 2023 21:03
mirianfsilva and others added 5 commits July 13, 2023 18:08
@mirianfsilva
update branch with develop
1451c48
@moneill0
fix: removed files added to commit by mistake
ea1190e 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
refactor: handling of default argument and pytest
58710e7 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
fix: fixed download assets pytest
d40cb0c 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
fix: fixed request handler
8562c35 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@coveralls
Copy link

coveralls commented Jul 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5762194987

  • 94 of 101 (93.07%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 96.058%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/genai/routers/tunes.py 6 13 46.15%
Totals Coverage Status
Change from base Build 5741180454: -0.2%
Covered Lines: 1974
Relevant Lines: 2055
💛 - Coveralls

@moneill0 moneill0 marked this pull request as ready for review July 19, 2023 14:44
@onkarbhardwaj
Merge branch 'develop' into update_tunes_api
d754bf3 
Signed-off-by: Onkar Bhardwaj <onkar.bhardwaj@gmail.com>
@onkarbhardwaj
Update responses.py
0aaa357 
Signed-off-by: Onkar Bhardwaj <onkar.bhardwaj@gmail.com>
@mirianfsilva
Updates: examples, doc strings and tune manager
7c45048 
- remove duplicate examples
- add complete example with all tune functionalities
- update doc strings
- download assets only if tune status is complete
- update delete tune: unable to delete tune if not completed or failed.

Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
Updates: examples, doc strings and tune manager
921b771 
Updates:  examples, doc strings and tune manager

Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
update tests cases, improve tune downloads and tune delete
2d5da28 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
merge develop
ac04a9a
@mirianfsilva
add download option in model class
243a028 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
vedem1192
vedem1192 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@vedem1192 vedem1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, but needs the update to the schema file

src/genai/schemas/tunes_params.py Outdated Show resolved Hide resolved
mirianfsilva and others added 2 commits August 7, 2023 14:02
@mirianfsilva @vedem1192
Update schemas
75ed79c 
Co-authored-by: Veronique <22043067+vedem1192@users.noreply.github.com>
Signed-off-by: Mírian Silva <mirianfrsilva@gmail.com>
@mirianfsilva
run pre-commit
0809717 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@vedem1192 vedem1192 merged commit 28b75f7 into IBM:develop Aug 9, 2023
4 checks passed
@vedem1192 vedem1192 deleted the update_tunes_api branch August 9, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirianfsilva mirianfsilva mirianfsilva approved these changes

@Tomas2D Tomas2D Tomas2D approved these changes

@vedem1192 vedem1192 vedem1192 approved these changes

@onkarbhardwaj onkarbhardwaj Awaiting requested review from onkarbhardwaj

@jpwsutton jpwsutton Awaiting requested review from jpwsutton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@moneill0 @coveralls @Tomas2D @vedem1192 @mirianfsilva @onkarbhardwaj