Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra parameters in GenerateParams #110

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Extra parameters in GenerateParams #110

merged 2 commits into from
Jul 24, 2023

Conversation

onkarbhardwaj
Copy link
Contributor

Status

READY

Description

Change config of pydantic schema in GenerateParams

Impacted Areas in Library

Schemas

Which issue(s) does this pull-request fix?

Closes: #109

Any special notes for your reviewer?

Checklist

  • Automated tests exist
  • Updated Package Requirements (if required, and with maintainers' approval)
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above
  • Link to relevant GitHub issue provided

generate params allows extra fields
fbdf1a7 
Signed-off-by: Onkar Bhardwaj <onkarbhardwaj@ibm.com>
@onkarbhardwaj onkarbhardwaj changed the base branch from main to develop July 24, 2023 15:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5646516428

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 96.213%
Totals Coverage Status
Change from base Build 5624698602: -0.002%
Covered Lines: 1880
Relevant Lines: 1954
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5647150323

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.215%
Totals Coverage Status
Change from base Build 5624698602: 0.0%
Covered Lines: 1881
Relevant Lines: 1955
💛 - Coveralls

@onkarbhardwaj onkarbhardwaj mentioned this pull request Jul 24, 2023
Closed
vedem1192
vedem1192 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@vedem1192 vedem1192 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected

fix Config of GenerateParams
b3d9c6e 
Signed-off-by: Onkar Bhardwaj <onkarbhardwaj@ibm.com>
@vedem1192 vedem1192 requested a review from Tomas2D July 24, 2023 16:09
@onkarbhardwaj onkarbhardwaj merged commit ec25538 into IBM:develop Jul 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomas2D Tomas2D Tomas2D approved these changes

@vedem1192 vedem1192 vedem1192 approved these changes

@jpwsutton jpwsutton Awaiting requested review from jpwsutton

@ameza13 ameza13 Awaiting requested review from ameza13

@moneill0 moneill0 Awaiting requested review from moneill0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra parameters in GenerateParams
4 participants
@onkarbhardwaj @coveralls @Tomas2D @vedem1192